integrate latest changes from Bevy #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R3DP1XL
force-pushed
the
bevy-7356f1586d74039f840bcfcf24af3e21c23e3c18
branch
2 times, most recently
from
a7ec058
to
e51dd20
Compare
R3DP1XL
changed the title
|
Do you know what is the sub-app thingy? |
R3DP1XL
force-pushed
the
bevy-7356f1586d74039f840bcfcf24af3e21c23e3c18
branch
from
76d7211
to
7f5455c
Compare
They were introduced as part of bevyengine/bevy#3175 to support their new pipelined renderer I think. |
kirdaybov
reviewed
Dec 17, 2021
| let inner_size = winit_window.inner_size(); | ||
|
|
||
| // move origin to bottom left | ||
| let y_position = f64::from(inner_size.height) - position.y; |
There was a problem hiding this comment.
Is this change intentional? I've changed the mouse cursor a couple of weeks ago to use top left as the origin
There was a problem hiding this comment.
Probably not you can revert back to your change. Mark it with a comment if possible.
There was a problem hiding this comment.
this part was not trivial to merge... changes on both sides if I recall.
please reintegrate your changes Kirill, and sorry if I lost something in the process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate latest Bevy changes
Sync to bevyengine/bevy@7356f15